fix: Cloud Code beforeFind trigger context is not isolated from prototype pollution by mtrezza · Pull Request #10570 · parse-community/parse-server

mtrezza · 2026-07-11T01:21:24Z

Issue

The beforeFind trigger context is not isolated from Object.prototype, unlike every other Cloud Code trigger. getRequestObject builds the trigger context with a null prototype (Object.assign(Object.create(null), context)), but the symmetric getRequestQueryObject used by beforeFind still assigned context: context || {}, so its request.context inherited Object.prototype.

Tasks

Add tests

…type pollution

parse-github-assistant · 2026-07-11T01:21:27Z

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
Group code into logical blocks. Add a short comment before each block to explain its purpose.
We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

coderabbitai · 2026-07-11T01:21:46Z

📝 Walkthrough

Walkthrough

Query trigger contexts are now created with null prototypes to prevent prototype pollution, and mutations made during beforeFind are propagated to the shared context used by afterFind. Regression tests cover isolation, pollution resistance, and mutation propagation.

Changes

Query trigger context isolation

Layer / File(s)	Summary
Null-prototype context construction `src/triggers.js`, `spec/vulnerabilities.spec.js`	Query trigger contexts use null-prototype objects, with tests verifying no inherited or polluted properties are exposed.
Mutation propagation between triggers `src/triggers.js`, `spec/vulnerabilities.spec.js`	Mutations made in `beforeFind` are copied into the `afterFind` context while both contexts retain null prototypes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

parse-community/parse-server#10352: Also hardens Cloud Code trigger contexts against prototype pollution.
parse-community/parse-server#8480: Also modifies trigger request construction in src/triggers.js.

Suggested reviewers: Moumouls

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Ignore

❌ Failed checks (1 error, 1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❌ Error	The PR description is missing the required Issue, Approach, and Tasks sections.	Add the template sections with an issue reference, a brief approach summary, and completed task checkboxes relevant to this PR.
Security Check	⚠️ Warning	`Object.assign(context, requestObject.context)` can turn a user-supplied `__proto__` key into prototype pollution on the shared context object.	Merge back only safe own keys or keep the shared context null-prototype too; never Object.assign untrusted keys into a plain object.
Engage In Review Feedback	❓ Inconclusive	Repo shows only code/test changes in one commit; no review-thread or comment history is available to verify engagement with feedback.	Provide the PR review thread or GitHub comments so I can confirm whether feedback was discussed before being resolved.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the required prefix and clearly describes the main fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-11T01:28:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.68%. Comparing base (cb9b542) to head (c599875).
⚠️ Report is 1 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10570   +/-   ##
=======================================
  Coverage   92.67%   92.68%           
=======================================
  Files         193      193           
  Lines       17007    17009    +2     
  Branches      248      248           
=======================================
+ Hits        15762    15764    +2     
  Misses       1224     1224           
  Partials       21       21

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# [9.10.0-alpha.7](9.10.0-alpha.6...9.10.0-alpha.7) (2026-07-11) ### Bug Fixes * Cloud Code beforeFind trigger context is not isolated from prototype pollution ([#10570](#10570)) ([bea001e](bea001e))

parseplatformorg · 2026-07-11T01:46:52Z

🎉 This change has been released in version 9.10.0-alpha.7

# [9.10.0](9.9.0...9.10.0) (2026-07-13) ### Bug Fixes * Cloud Code beforeFind trigger context is not isolated from prototype pollution ([#10570](#10570)) ([bea001e](bea001e)) * Cloud Function multipart requests bypass the maxUploadSize limit ([#10498](#10498)) ([f12e1c3](f12e1c3)) * Denial of service via exponential-time processing of deeply nested query operators ([GHSA-cgxm-vr2f-6fj8](GHSA-cgxm-vr2f-6fj8)) ([#10511](#10511)) ([1103c7a](1103c7a)) * Endpoints `/login` and `/verifyPassword` disclose MFA secrets and protected fields when `_User` get is denied ([GHSA-75v4-m273-5j49](GHSA-75v4-m273-5j49)) ([#10492](#10492)) ([83e90ed](83e90ed)) * GeoPoint distance queries fail with an internal server error on MongoDB 8.3 and later ([#10572](#10572)) ([b706c22](b706c22)) * GraphQL "Did you mean" validation suggestions disclose schema to unauthenticated callers ([GHSA-8cph-rgr4-g5vj](GHSA-8cph-rgr4-g5vj)) ([#10467](#10467)) ([155123a](155123a)) * GraphQL error messages disclose pointer and relation target class names when public introspection is disabled ([GHSA-r2g6-4f6j-f6rf](GHSA-r2g6-4f6j-f6rf)) ([#10568](#10568)) ([cb9b542](cb9b542)) * GraphQL error messages disclose required input field names when public introspection is disabled ([GHSA-2fgh-8j2g-w354](GHSA-2fgh-8j2g-w354)) ([#10566](#10566)) ([d96c945](d96c945)), closes [GHSA-2f#8j2g-w354](https://github.com/GHSA-2f/issues/8j2g-w354) [/github.com/parse-community/parse-server/security/advisories/GHSA-2f#8j2g-w354](https://github.com//github.com/parse-community/parse-server/security/advisories/GHSA-2f/issues/8j2g-w354) * GraphQL variable-coercion suggestions disclose schema to unauthenticated callers ([GHSA-9g8f-h8f3-hjcm](GHSA-9g8f-h8f3-hjcm)) ([#10563](#10563)) ([2625489](2625489)) * LiveQuery discloses object data to a subscriber across an ACL read-access change ([GHSA-97pr-9hgg-3p8r](GHSA-97pr-9hgg-3p8r)) ([#10515](#10515)) ([e9c85df](e9c85df)) * LiveQuery subscriptions leak when a client reuses a subscribe requestId ([#10499](#10499)) ([3fad4fb](3fad4fb)) * Middleware route checks do not match routing-equivalent path variants (trailing slash, case) ([#10501](#10501)) ([f861210](f861210)) * NumberOrBoolean config option (cluster) value not coerced from env/CLI ([#10531](#10531)) ([459786f](459786f)) * Pre-authentication denial of service via client version header regex backtracking ([GHSA-38m6-82c8-4xfm](GHSA-38m6-82c8-4xfm)) ([#10463](#10463)) ([56c159e](56c159e)) * rateLimit on exact static routes is bypassed by appending a query string ([#10500](#10500)) ([880e8e6](880e8e6)) * Relation `$relatedTo` query bypasses `protectedFields` and owning-object ACL ([GHSA-wmwx-jr2p-4j4r](GHSA-wmwx-jr2p-4j4r)) ([#10493](#10493)) ([43658f1](43658f1)) * Server option routeAllowList is bypassable through batch sub-requests ([GHSA-p84r-h6rx-f2xr](GHSA-p84r-h6rx-f2xr)) ([#10482](#10482)) ([552c6dd](552c6dd)) * Stored XSS via malformed Content-Type bypassing file upload extension blocklist ([GHSA-r899-h629-j84r](GHSA-r899-h629-j84r)) ([#10521](#10521)) ([cce91e5](cce91e5)) * Stored XSS via non-standard file extension bypassing file upload extension blocklist ([GHSA-v8x7-r927-cc93](GHSA-v8x7-r927-cc93)) ([#10505](#10505)) ([be12a60](be12a60)) * Stored XSS via trailing-dot filename bypassing file upload extension blocklist ([GHSA-7wqv-xjf3-x35v](GHSA-7wqv-xjf3-x35v)) ([#10489](#10489)) ([66484ce](66484ce)) ### Features * Add option to disallow aggregation pipelines for the read-only master key ([#10517](#10517)) ([816078f](816078f))

parseplatformorg · 2026-07-13T01:05:47Z

🎉 This change has been released in version 9.10.0

* commit 'b5ca12fa5e2c951e0cd4ac45ec11e23430da323b': (48 commits) chore(release): 9.10.0 [skip ci] empty commit to trigger CI chore(release): 9.10.0-alpha.8 [skip ci] fix: GeoPoint distance queries fail with an internal server error on MongoDB 8.3 and later (parse-community#10572) chore(release): 9.10.0-alpha.7 [skip ci] fix: Cloud Code beforeFind trigger context is not isolated from prototype pollution (parse-community#10570) chore(release): 9.10.0-alpha.6 [skip ci] fix: GraphQL error messages disclose pointer and relation target class names when public introspection is disabled ([GHSA-r2g6-4f6j-f6rf](GHSA-r2g6-4f6j-f6rf)) (parse-community#10568) chore(release): 9.10.0-alpha.5 [skip ci] fix: GraphQL error messages disclose required input field names when public introspection is disabled ([GHSA-2fgh-8j2g-w354](GHSA-2fgh-8j2g-w354)) (parse-community#10566) chore(release): 9.10.0-alpha.4 [skip ci] fix: GraphQL variable-coercion suggestions disclose schema to unauthenticated callers ([GHSA-9g8f-h8f3-hjcm](GHSA-9g8f-h8f3-hjcm)) (parse-community#10563) chore(release): 9.10.0-alpha.3 [skip ci] fix: NumberOrBoolean config option (cluster) value not coerced from env/CLI (parse-community#10531) chore(release): 9.10.0-alpha.2 [skip ci] fix: Stored XSS via malformed Content-Type bypassing file upload extension blocklist ([GHSA-r899-h629-j84r](GHSA-r899-h629-j84r)) (parse-community#10521) test: Rate limit requestMethods is scoped to the configured HTTP methods (parse-community#10520) chore(release): 9.10.0-alpha.1 [skip ci] feat: Add option to disallow aggregation pipelines for the read-only master key (parse-community#10517) chore(release): 9.9.1-alpha.13 [skip ci] ... # Conflicts: # package.json

fix: Cloud Code beforeFind trigger context is not isolated from proto…

c599875

…type pollution

mtrezza merged commit bea001e into parse-community:alpha Jul 11, 2026
24 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label Jul 11, 2026

mtrezza deleted the fix/beforefind-context-prototype-isolation branch July 11, 2026 01:47

parseplatformorg added the state:released Released as stable version label Jul 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Cloud Code beforeFind trigger context is not isolated from prototype pollution#10570

fix: Cloud Code beforeFind trigger context is not isolated from prototype pollution#10570
mtrezza merged 1 commit into
parse-community:alphafrom
mtrezza:fix/beforefind-context-prototype-isolation

mtrezza commented Jul 11, 2026 •

edited

Loading

Uh oh!

parse-github-assistant Bot commented Jul 11, 2026

Uh oh!

coderabbitai Bot commented Jul 11, 2026 •

edited

Loading

Walkthrough

Changes

Pre-merge checks failed

Uh oh!

codecov Bot commented Jul 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

parseplatformorg commented Jul 11, 2026

Uh oh!

parseplatformorg commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

mtrezza commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Tasks

Uh oh!

parse-github-assistant Bot commented Jul 11, 2026

Uh oh!

coderabbitai Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Pre-merge checks failed

❌ Failed checks (1 error, 1 warning, 1 inconclusive)

Uh oh!

codecov Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

parseplatformorg commented Jul 11, 2026

Uh oh!

parseplatformorg commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mtrezza commented Jul 11, 2026 •

edited

Loading

coderabbitai Bot commented Jul 11, 2026 •

edited

Loading

codecov Bot commented Jul 11, 2026 •

edited

Loading